[ROCm] Enable fused_silu_mul_block_quant on ROCm#38817
Open
gshtras wants to merge 4 commits intovllm-project:mainfrom
Open
[ROCm] Enable fused_silu_mul_block_quant on ROCm#38817gshtras wants to merge 4 commits intovllm-project:mainfrom
gshtras wants to merge 4 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
gshtras
requested review from
BoyuanFeng,
LucasWilkinson,
ProExpertProg,
WoosukKwon,
mgoin,
tlrmchlsmth,
vadiklyutiy,
yewentao256,
youkaichao and
zou3519
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables the silu_and_mul_per_block_quant kernel for ROCm by removing conditional compilation guards in csrc/ops.h and csrc/torch_bindings.cpp, and adjusting CMakeLists.txt. It also updates include paths to use relative addressing and refactors kernel tests and fusion passes to be more platform-agnostic by using current_platform helpers. One issue was identified in csrc/torch_bindings.cpp where a comment describing DeepSeek V3 GEMM was accidentally moved and is now incorrectly associated with the SiLU quantization operator.
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
ProExpertProg
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another follow up for #32996
This time properly enabling the new kernel on ROCm instead of guarding
Include path changes are needed because the hipify script would ignore absolute include paths and multiple slightly different versions of the same header would end up being included, causing symbol redefinition errors.
Setting the device index globally in the test solves the IMA error from torch on ROCm